Skip to content

Conversation

@microbit-matt-hillsdon
Copy link
Contributor

@microbit-matt-hillsdon microbit-matt-hillsdon commented Apr 15, 2025

Fixes #421

Demo: https://insert-connection.blockly-keyboard-experimentation.pages.dev/

Problems with this PR:

  • Select create canvas block, insert statement block, escape to abort. We delete more than we intend.
  • Not doesn't wrap around true in test of if by default if on if
Screen.Recording.2025-04-15.at.14.24.59.mov

To raise as separate issues:

  • Post-abort cursor position isn't great (like delete in general).
  • Undo has too many steps.

Insert has the side effects of popping out blocks that isn't undone by moving
to the next position.
undo is still multiple steps but will need Blockly input for that
@microbit-matt-hillsdon microbit-matt-hillsdon changed the title feat: avoid insert then move and delete on abort feat: avoid insert then move; delete on abort Apr 15, 2025
@microbit-matt-hillsdon
Copy link
Contributor Author

Closing in favour of #455, thanks @rachel-fenichel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected 'pop out' of conditional / logic block

1 participant